Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset CFLAGS on python recipe #5594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

singiamtel
Copy link
Collaborator

I think we currently build without -O2 when using our own OpenSSL, seems like an oversight

@singiamtel singiamtel requested a review from a team as a code owner August 28, 2024 09:08
@@ -54,7 +54,7 @@ esac
if [[ $OPENSSL_ROOT ]]; then
export CPATH="$OPENSSL_ROOT/include:$OPENSSL_ROOT/include/openssl:$CPATH"
export CPPFLAGS="-I$OPENSSL_ROOT/include -I$OPENSSL_ROOT/include/openssl $CPPFLAGS"
export CFLAGS="-I$OPENSSL_ROOT/include -I$OPENSSL_ROOT/include/openssl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe what we should do is really drop CFLAFS, since most likely CPPFLAGS is enough. Could you check?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compilation without CFLAGS ends successfully, but I get a crash on env activation with this error:

alienv enter Python/latest-ubuntu2204_x86-64-o2
Loading Python/latest-ubuntu2204_x86-64-o2
  Module ERROR: /home/admin/test_openssl_py/sw/ubuntu2204_x86-64/Python/v3.9.16-local1/bin/python3: error while loading shared libraries: libcrypt.so.2: cannot open shared object file: No such file or directory
        while executing
    "exec $PKG_ROOT/bin/python3 -c "import certifi; print(certifi.where())""
        (file "/home/admin/test_openssl_py/sw/MODULES/ubuntu2204_x86-64/Python/latest-ubuntu2204_x86-64-o2" line 26)
    Please contact <root@localhost>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then it's needed...

@singiamtel singiamtel changed the title Don't reset CFLAGS on python recipe WIP: Don't reset CFLAGS on python recipe Aug 28, 2024
@singiamtel singiamtel changed the title WIP: Don't reset CFLAGS on python recipe Don't reset CFLAGS on python recipe Aug 28, 2024
@singiamtel singiamtel changed the title Don't reset CFLAGS on python recipe WIP: Don't reset CFLAGS on python recipe Oct 28, 2024
@singiamtel singiamtel changed the title WIP: Don't reset CFLAGS on python recipe Don't reset CFLAGS on python recipe Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants